-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10842/#review19952
-----------------------------------------------------------
Ship it!
committed
commit 75832c893b342c905d692e893a46af3dfd838943
Author: Marcus Sorensen <shadow...@gmail.com>
Date: Tue Apr 30 15:19:30 2013 +0100
CLOUDSTACK-2281: Fix NPE in the planner, in the case that pool ID cannot be
looked up in database when deploying a VM
This fixes a null pointer if selected pool on which to deploy is unable
to be looked up via id. Used the same coding style found in the original
code (large if/else block).
If this is accepted, I'll fix master too. This patch doesn't apply
cleanly, but the code is very similar.
Testing:
Fixed broken system, tested against devcloud to ensure that it didn't
break a stock/fresh install (advanced zone with 3 storage pools).
Restarted VMs to ensure that the planner still functioned that way as
well.
- Chip Childers
On April 29, 2013, 10:01 p.m., Marcus Sorensen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10842/
> -----------------------------------------------------------
>
> (Updated April 29, 2013, 10:01 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prachi Damle, and edison su.
>
>
> Description
> -------
>
> This fixes a null pointer if selected pool on which to deploy is unable to be
> looked up via id. Used the same coding style found in the original code
> (large if/else block).
>
> If this is accepted, I'll fix master too. This patch doesn't apply cleanly,
> but the code is very similar.
>
>
> This addresses bug CLOUDSTACK-2281.
>
>
> Diffs
> -----
>
> server/src/com/cloud/deploy/FirstFitPlanner.java 31fc43c
>
> Diff: https://reviews.apache.org/r/10842/diff/
>
>
> Testing
> -------
>
> Fixed broken system, tested against devcloud to ensure that it didn't break a
> stock/fresh install (advanced zone with 3 storage pools). Restarted VMs to
> ensure that the planner still functioned that way as well.
>
>
> Thanks,
>
> Marcus Sorensen
>
>
