-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10846/#review20012
-----------------------------------------------------------



test/selenium/smoke/Login_and_Accounts.py
<https://reviews.apache.org/r/10846/#comment41244>

    For this kind of global configurations, what we did in marvin, is that, 
inject global configurations into each unit test case. For example, we can add 
a command line option(mgt server ip) in test/selenium/smoke/main.py, then 
inject mgt server ip address into each unit test case:  setattr(test, 
"base_url", "http://mgt-serv-ip-got-from-command-line:8080/";), then inside each 
unit test, self.base_url is already initialized.


- edison su


On May 1, 2013, 5:48 p.m., Parth Jagirdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10846/
> -----------------------------------------------------------
> 
> (Updated May 1, 2013, 5:48 p.m.)
> 
> 
> Review request for cloudstack, David Nalley, Chip Childers, and edison su.
> 
> 
> Description
> -------
> 
> Selenium Headless configuration using PhantomJS.
> 
> Fixed Readme Typos, and added an extra field for PhantomJS and How to 
> configure Management Server IP.
> 
> 
> This addresses bug Cloudstack-2282.
> 
> 
> Diffs
> -----
> 
>   test/selenium/ReadMe.txt 30b0e0d 
>   test/selenium/lib/initialize.py e8cc49a 
>   test/selenium/smoke/Login_and_Accounts.py c5132d9 
> 
> Diff: https://reviews.apache.org/r/10846/diff/
> 
> 
> Testing
> -------
> 
> NA.
> 
> 
> Thanks,
> 
> Parth Jagirdar
> 
>

Reply via email to