----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10833/ -----------------------------------------------------------
(Updated May 2, 2013, 10:02 a.m.) Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and Chiradeep Vittal. Changes ------- Resolved the conflicts. Description ------- Source NAT on private gateway feature This addresses bug CLOUDSTACK-1828. Diffs (updated) ----- api/src/com/cloud/network/NetworkService.java 6c9bebc api/src/com/cloud/network/vpc/PrivateIp.java 857fc22 api/src/com/cloud/network/vpc/VpcGateway.java 1756616 api/src/com/cloud/network/vpc/VpcService.java 07ce89b api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java 9fd736f api/src/org/apache/cloudstack/api/response/PrivateGatewayResponse.java 4123477 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 7148e07 patches/systemvm/debian/config/opt/cloud/bin/vpc_privateGateway.sh a09d8f7 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 0064edf plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 38c9f86 plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 46ae35a server/src/com/cloud/api/ApiResponseHelper.java 6090ff0 server/src/com/cloud/network/NetworkServiceImpl.java ae0e421 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java bdfac06 server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 2595a6a server/src/com/cloud/network/vpc/PrivateIpAddress.java 826bea2 server/src/com/cloud/network/vpc/PrivateIpVO.java e6616ae server/src/com/cloud/network/vpc/VpcGatewayVO.java 718e4df server/src/com/cloud/network/vpc/VpcManagerImpl.java bc7bb0c server/test/com/cloud/network/MockNetworkManagerImpl.java e9987bd server/test/com/cloud/vpc/MockNetworkManagerImpl.java 9b18358 server/test/com/cloud/vpc/MockVpcManagerImpl.java 0f26928 setup/db/db/schema-410to420.sql 69bf886 Diff: https://reviews.apache.org/r/10833/diff/ Testing ------- 1. created the private gateway with source nat enable. 2. created private gateway with with source nat disable. 3. NAT rules for private gateway interface are configured correctly on VR. Thanks, Jayapal Reddy
