Saksham,
> Since broadcast is an assignable IP so it should be a part of Reserved range. > Closing the request. Currently last IP of guest ip range is being included in reserved range. This needs to be fixed. User is providing CIDR to specify ip range, then we should ensure all IPs that come under that CIDR needs to be considered for guests. Hence CIDR 10.1.1.0/26 means reservation would be 10.1.1.64 to 10.1.1.254 instead of 10.1.1.63-10.1.1.254 as per current behaviour. Please fix this and resubmit the patch. Regards, Sateesh From: Saksham Srivastava [mailto:nore...@reviews.apache.org] On Behalf Of Saksham Srivastava Sent: 30 April 2013 14:10 To: Sateesh Chodapuneedi; Murali Reddy Cc: Saksham Srivastava; cloudstack Subject: Re: Review Request: CLOUDSTACK-1748: IP Reservation results in reserving the broadcast IP of the network as well This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10078/ Since we are not creating subnets for guest CIDR, there is no need for a separate broadcast IP. The guest Broadcast will be same as the Network Broadcast. Currently this is the behaviour : CIDR 10.1.1.0/26 Network CIDR 10.1.1.0/24 Reserved Range : 10.1.1.63-10.1.1.254 CIDR 10.1.1.224/27 Network CIDR 10.1.1.0/24 Reserved Range : 10.1.1.1-10.1.1.224 CIDR 10.1.1.32/27 Network CIDR 10.1.1.0/24 Reserved Range : 10.1.1.1-10.1.1.32 , 10.1.1.63-10.1.1.254 Since broadcast is an assignable IP so it should be a part of Reserved range. Closing the request. - Saksham On March 22nd, 2013, 10:04 a.m., Saksham Srivastava wrote: Review request for cloudstack, Murali Reddy and Sateesh Chodapuneedi. By Saksham Srivastava. Updated March 22, 2013, 10:04 a.m. Description While reserving IPs, broadcast IPs of guestvmcidr is also getting reserved. Testing CIDR : 10.1.1.0/26 (10.1.1.1-10.1.1.62, Broadcast: 10.1.1.63) Network CIDR: 10.1.1.0/24 (10.1.1.1-10.1.1.254, Broadcast: 10.1.1.255) Reserved Range: 10.1.1.64-10.1.1.254 Diffs * server/src/com/cloud/api/ApiResponseHelper.java (663139d) View Diff<https://reviews.apache.org/r/10078/diff/>
