Hi Hiroaki, Any update?
--Sheng On Fri, Apr 26, 2013 at 1:28 PM, Sheng Yang <sh...@yasker.org> wrote: > Hi Hiroaki, > > Any update on the patch? I am planning to use it on PVLAN VM migration > support. > > --Sheng > > > On Thu, Apr 18, 2013 at 6:33 PM, Hiroaki Kawai > <ka...@stratosphere.co.jp>wrote: > >> >> >> > On April 18, 2013, 10:45 p.m., Chiradeep Vittal wrote: >> > > Looks good. Is this the final? >> >> Yes. :-) >> >> Ready to ship? Any comments from anybody else? >> >> >> - Hiroaki >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/9871/#review19414 >> ----------------------------------------------------------- >> >> >> On April 11, 2013, 7:22 a.m., Hiroaki Kawai wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/9871/ >> > ----------------------------------------------------------- >> > >> > (Updated April 11, 2013, 7:22 a.m.) >> > >> > >> > Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. >> > >> > >> > Description >> > ------- >> > >> > The location of the virtual machine is provided by DeployDestination, >> which will be passed in NetworkGuru#reserve and NetworkElement#prepare. >> > >> > During the virtual machine migration, it actually changes >> DeployDestination and it looks like that it will tell that event to network >> components as it has NetworkManager#prepareNicForMigration. The problem is >> that althogh the interface has that method, NetworkManagerImpl does not >> tell the DeployDestination changes to network components. >> > >> > So IMHO, we need to add calls of NetworkGuru#reserve and >> NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And >> then, we also need to add calls NetworkGuru#release and >> NetworkElement#release after the migration, otherwise the network resources >> that plugin reserved will be kept even when the vm leaves off. >> > >> > Created a first minimum patch to show the concept. >> > >> > >> > This addresses bug CLOUDSTACK-1638. >> > >> > >> > Diffs >> > ----- >> > >> > api/src/com/cloud/network/NetworkMigrationResponder.java PRE-CREATION >> > server/src/com/cloud/network/NetworkManager.java 4124b19 >> > server/src/com/cloud/network/NetworkManagerImpl.java a98bdd4 >> > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 9230f4a >> > >> > Diff: https://reviews.apache.org/r/9871/diff/ >> > >> > >> > Testing >> > ------- >> > >> > >> > Thanks, >> > >> > Hiroaki Kawai >> > >> > >> >> >
