> On May 8, 2013, 8:23 a.m., Prasanna Santhanam wrote:
> > Thanks these are good tests! I've removed the debug statements you put in 
> > print since those won't show in the default test run. I'll also break down 
> > these tests into three suites:
> > 
> > a) test_regions (tests basic creation - goes into the 
> > tests/integration/smoke so it can be part of the checkin tests)
> > b) test_regions (extended regions tests in tests/integration/component so 
> > it runs with our regression
> > c) test_regions_accounts (account CRUD operation in relation to regions)
> > 
> > commit 5ef2f1f26fcd159cb48b25882ea10cb3fc44d1b9
> > Author: Sangeetha Hariharan <sangeetha.hariha...@citrix.com>
> > Date:   Fri May 3 17:02:32 2013 -0700
> > 
> >     CLOUDSTACK-2329, CLOUDSTACK-1820: Tests for regions
> >     
> >     Marvin tests and corresponding library changes for the regions feature.
> >     
> >     Signed-off-by: Prasanna Santhanam <t...@apache.org>
> >

All tests run perfectly now:
~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
--with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/component/test_regions.py --load
Test for duplicate checks on region id ... ok
Test for duplicate checks on region name ... ok
Test for update Region ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.129s

OK
------------------------------------------------------------
~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
--with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/smoke/test_regions.py --load
Test for create region ... ok

----------------------------------------------------------------------
Ran 1 test in 0.057s

OK
------------------------------------------------------------
~/workspace/cloudstack/incubator-cloudstack(branch:master*) » nosetests 
--with-marvin --marvin-config=setup/dev/advanced.cfg 
test/integration/component/test_regions_accounts.py --load
Test for creating account by passing id parameter ... ok
Test for creating User by passing id parameter ... ok
Test for creating Domain by passing id parameter ... ok

----------------------------------------------------------------------
Ran 3 tests in 10.346s

OK
------------------------------------------------------------


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10936/#review20296
-----------------------------------------------------------


On May 4, 2013, 4:13 a.m., sangeetha hariharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10936/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 4:13 a.m.)
> 
> 
> Review request for cloudstack, Prasanna Santhanam and Girish Shilamkar.
> 
> 
> Description
> -------
> 
> Added Test cases to test APIs relating to Regions feature.
> 
> 
> This addresses bug CLOUDSTACK-1820.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_regions.py PRE-CREATION 
>   tools/marvin/marvin/integration/lib/base.py bebf2b5 
> 
> Diff: https://reviews.apache.org/r/10936/diff/
> 
> 
> Testing
> -------
> 
> Executed the scripts  against a CloudStack set up and made sure they executed 
> successfully.
> 
> 
> Thanks,
> 
> sangeetha hariharan
> 
>

Reply via email to