I have finished the refactoring (ran into eclipse refactoring bugs). I am now trying to test. But I realized that it will be good to have tool/script that does most of this refactoring rather than using eclipse. Anyone knows any such tool/script ? Otherwise I plan to make one.
Thanks, Dharmesh On Wed, May 8, 2013 at 9:08 PM, Dharmesh Kakadia <dhkaka...@gmail.com>wrote: > I have started refactoring !! I am planning to finish refactoring by > tomorrow. I will then need help and guidance in doing testing,branching > etc. Let's try this out !! > > Thanks, > Dharmesh > > > On Wed, May 8, 2013 at 7:20 PM, Sebastien Goasguen <run...@gmail.com>wrote: > >> >> On May 8, 2013, at 9:30 AM, Chip Childers <chip.child...@sungard.com> >> wrote: >> >> > Dharmesh, >> > >> > I'd also suggest that you actually plan on submitting this after the 4.2 >> > feature freeze, to be included in 4.3. This is the type of change that >> > has bitten us with almost every release... and doing it close to the >> > end of the merge window may not be a good idea. Our general preference >> > is to do these types of changes in master right *after* the latest >> > feature release has it's branch cut. >> > >> > -chip >> >> To add to that, feature freeze for 4.2 is scheduled to be 5/31. >> >> We could have your code in a feature branch before that, and merge it >> early june. It would then be included in 4.3 >> >> >> >> > >> > On Wed, May 08, 2013 at 10:29:22AM +0530, Dharmesh Kakadia wrote: >> >> ok. I will go with that. >> >> >> >> Thanks, >> >> Dharmesh >> >> >> >> On Wed, May 8, 2013 at 1:08 AM, Chip Childers < >> chip.child...@sungard.com>wrote: >> >> >> >>> On Tue, May 07, 2013 at 11:14:12PM +0530, Dharmesh Kakadia wrote: >> >>>> Hi, >> >>>> >> >>>> I am trying to move java package structure from com.cloud to >> org.apache ( >> >>>> https://issues.apache.org/jira/browse/CLOUDSTACK-212). I am >> thinking of >> >>>> doing it the following way (Totally newbie), needed feedback on that. >> >>>> >> >>>> 1. grep "com.cloud" on the entire repo. >> >>>> 2. update all package declarations using eclipse. >> >>>> 3. Update scripts etc found in 1 manually. >> >>>> >> >>>> Will it be a good way to do it ? Any better suggestion ? >> >>>> >> >>>> Thanks, >> >>>> Dharmesh >> >>> >> >>> That seems like a reasonable approach. We will probably want to >> create >> >>> a branch when you submit a patch for this, and apply it there... just >> >>> to spend some time ensuring that the changes work. >> >>> >> >>> -chip >> >>> >> >> >
