----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10942/#review20478 -----------------------------------------------------------
server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java <https://reviews.apache.org/r/10942/#comment42203> acl_id for gateway cannot be null server/src/com/cloud/network/vpc/VpcManagerImpl.java <https://reviews.apache.org/r/10942/#comment42202> Import should be replaced with single imports setup/db/db/schema-410to420.sql <https://reviews.apache.org/r/10942/#comment42201> acl_id for vpc_gateway can be not null field. gateway will be associated witl acl at all times - Kishan Kavala On May 10, 2013, 12:52 p.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10942/ > ----------------------------------------------------------- > > (Updated May 10, 2013, 12:52 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Kishan Kavala, and Murali > Reddy. > > > Description > ------- > > ACL on private gateway feature. > ACLs are implemented with the container model > > > This addresses bug CLOUDSTACK-768. > > > Diffs > ----- > > api/src/com/cloud/agent/api/routing/NetworkElementCommand.java 41ae80f > api/src/com/cloud/network/NetworkService.java bea92dc > api/src/com/cloud/network/element/VpcProvider.java 81b1cf3 > api/src/com/cloud/network/firewall/NetworkACLService.java 5f068a3 > api/src/com/cloud/network/vpc/VpcGateway.java e3530d0 > api/src/com/cloud/network/vpc/VpcService.java 23e2764 > > api/src/org/apache/cloudstack/api/command/admin/vpc/CreatePrivateGatewayCmd.java > 2055695 > > api/src/org/apache/cloudstack/api/command/user/network/ReplaceNetworkACLListCmd.java > b8abc78 > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > b9bda4d > patches/systemvm/debian/config/opt/cloud/bin/vpc_privategw_acl.sh > PRE-CREATION > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 8fe8c88 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 030eff0 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > bac361d > server/src/com/cloud/network/NetworkServiceImpl.java 7045eff > server/src/com/cloud/network/element/VpcVirtualRouterElement.java 8b0c58a > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManager.java > 306b1a8 > > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java > 1d901d9 > server/src/com/cloud/network/vpc/NetworkACLManager.java 1b1e958 > server/src/com/cloud/network/vpc/NetworkACLManagerImpl.java 67547c6 > server/src/com/cloud/network/vpc/NetworkACLServiceImpl.java 2844dcb > server/src/com/cloud/network/vpc/PrivateGatewayProfile.java 20947db > server/src/com/cloud/network/vpc/VpcGatewayVO.java e8dcb46 > server/src/com/cloud/network/vpc/VpcManagerImpl.java 4af9278 > server/src/com/cloud/network/vpc/dao/VpcGatewayDao.java 600d67f > server/src/com/cloud/network/vpc/dao/VpcGatewayDaoImpl.java a1cd934 > server/test/com/cloud/vpc/MockVpcManagerImpl.java b4851d6 > server/test/com/cloud/vpc/MockVpcVirtualNetworkApplianceManager.java > ef5478b > server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java a483291 > setup/db/db/schema-410to420.sql 8fdf0a0 > > Diff: https://reviews.apache.org/r/10942/diff/ > > > Testing > ------- > > 1. Tested creation of private gateway with acl id > 2. replacenetworkacl for privategateway id > 3. add new acl item and checking the applying item on private gw > 4. restart router and see the rules are added or not. > > > Thanks, > > Jayapal Reddy > >
