----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11019/ -----------------------------------------------------------
(Updated May 14, 2013, 10:35 p.m.) Review request for cloudstack, Chip Childers, Sheng Yang, Sateesh Chodapuneedi, Kelven Yang, and Animesh Chaturvedi. Changes ------- Uploading fully tested vmware changes for pvlan support. Tests carried out: ================== Step 0. Provision PVLAN primary/isolated secondary VLAN on physical switch that the physical hosts will connect to, following appropriate manuals of the switch vendor. Step 1. Set the vmware.use.dvswitch global flag to true, restart mgmt server. Step 2. Create vmware cluster in vCenter. Enable cluster for vMotion. Step 3. Create vmware DVS on the vmware datacenter that the cluster belongs to. Step 4. Create cloudstack zone/vmware cluster on mgmt server. Step 5. Login as admin to the mgmt server, and under - Infrastructure -> Zones view all -> your zone -> Physical network tab -> Physical network name -> Guest configure -> Network tab -> add Guest Network : create a pvlan enabled advanced shared network (you can use the "Offering for shared networks" network offering available in the drop down menu). Specify the primary (promiscuous vlan id) and the secondary isolated pvlan id. Specify valid routable IP gateway/ip range/netmask values. Step 6. Create a guest VM having the above network. It should come up with an eth0 interface plumbed with a DHCP IP picked from the ip address range provided in step 5. Ping the router VM's ip (on the same subnet) - it should go through. Step 7. Create another guest VM having the same network. It should also come up with an IP picked from the ip address range in step 5. This VM should be able to ping the router VM ip, but not the guest VM created in step 6. Step 8. Create an isolated network under Network -> Add Guest network. Create a new guest VM having both this new isolated network and the shared pvlan network created above. The VM should come up fine with two eth interfaces, each having an ip range from the specified ranges. Same ping behavior must be observed for interfaces between guest VMs in the pvlan network. Step 9. vMotion the guest VMs from one physical host to another. The migration must be smooth, the VM up, with no change seen in network configuration or behavior. Description ------- Please find attached the diffs for pvlan support for vmware DVSwitch deployments on cloudstack. You will find two diffs - the parent diff is Sateesh's fix for CLOUSTACK-2316 which is needed to be cherry-picked on the pvlan branch from the master. The other diff contains the changes for pvlan support. These diffs do not contain changes for pvlan provisioning on the Cisco Nexus 1000v distributed virtual switch. This addresses bug CLOUDSTACK-1456. Diffs (updated) ----- api/src/com/cloud/agent/api/PlugNicCommand.java b896e45 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 99ad1ca server/src/com/cloud/network/NetworkManagerImpl.java 7a09eb5 server/src/com/cloud/network/NetworkModelImpl.java bd62886 server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java bdfac06 server/src/com/cloud/vm/UserVmManagerImpl.java 683f0da server/src/com/cloud/vm/VirtualMachineManagerImpl.java b0d6378 vmware-base/src/com/cloud/hypervisor/vmware/mo/DistributedVirtualSwitchMO.java 247be2a vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java 7f323c5 Diff: https://reviews.apache.org/r/11019/diff/ Testing ------- The code has been tested on the Vmware DVSwitch for advanced shared networks on vmware cluster deployments on cloudstack. Unit tests will be the same as those provided by Sheng as part of the overall PVLAN support for XenServer and KVM, and will exercise the vmware pvlan code path when user VMs are created with vNICs sitting on advanced shared networks that have the optional Private VLAN value set during their creation. VM live migration using vmware vMotion has also been tested with these changes on vmware and it works as expected. Further testing will be carried out and this review request will be updated accordingly. Thanks, Venkata Siva Vijayendra Bhamidipati
