----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11067/#review20564 -----------------------------------------------------------
Girish, thanks for the patch. I'm afraid the intentions are not clear for smoke and component suites. I've recorded them here: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Marvin+-+Testing+with+Python#Marvin-TestingwithPython-ExistingTests Smoke tests only test the happy-path of the feature. Simple usecases that ensure that the feature is not outright broken are included here. Typically these can be run quickly from the developer environment itself using simulator or devcloud. Component is where all the in-depth test cases from test plans should be. Can you please move these tests to the component suites? - Prasanna Santhanam On May 11, 2013, 12:37 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11067/ > ----------------------------------------------------------- > > (Updated May 11, 2013, 12:37 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and sangeetha hariharan. > > > Description > ------- > > Add testcases for Affinity/Anti-Affinity Rules > > > This addresses bug CLOUDSTACK-2254. > > > Diffs > ----- > > test/integration/smoke/test_affinity_groups.py e0e1a17 > tools/marvin/marvin/integration/lib/base.py ecdc841 > > Diff: https://reviews.apache.org/r/11067/diff/ > > > Testing > ------- > > The tests which are not skipped are working. > > > Thanks, > > Girish Shilamkar > >
