On Wed, May 15, 2013 at 04:48:58PM +0200, Wei ZHOU wrote: > Hi Chip, > > Yes. and the patch for CLOUDSTACK-962 as well. Thanks! > https://reviews.apache.org/r/11181/ > > Wei
Both were applied to 4.1. Can you please review to be sure that they are in correctly. Also, do either patch still need to be applied to master? Specify the review or commit sh and I'll push it over there. > > > 2013/5/15 Chip Childers <chip.child...@sungard.com> > > > Should this be applied to 4.1? > > > > -chip > > > > On Wed, May 15, 2013 at 11:16:57AM +0000, Kishan Kavala wrote: > > > > > > ----------------------------------------------------------- > > > This is an automatically generated e-mail. To reply, visit: > > > https://reviews.apache.org/r/11157/#review20572 > > > ----------------------------------------------------------- > > > > > > Ship it! > > > > > > > > > commit 737063891592af1d896f150cca02ff3d63a0198c > > > > > > - Kishan Kavala > > > > > > > > > On May 14, 2013, 6:02 p.m., Wei Zhou wrote: > > > > > > > > ----------------------------------------------------------- > > > > This is an automatically generated e-mail. To reply, visit: > > > > https://reviews.apache.org/r/11157/ > > > > ----------------------------------------------------------- > > > > > > > > (Updated May 14, 2013, 6:02 p.m.) > > > > > > > > > > > > Review request for cloudstack and Kishan Kavala. > > > > > > > > > > > > Description > > > > ------- > > > > > > > > This is the additional patch for CLOUDSTACK-685 (and CLOUDSTACK-721 as > > well) after this commit > > > > > > https://git-wip-us.apache.org/repos/asf/cloudstack/repo?p=cloudstack.git;a=commit;h=cd7f7716155c3cd2d29b97d7ea302518d81fdfab > > > > > > > > PrepareStop part in VirtualNetworkApplianceImpl.java need to be > > changed as well. > > > > > > > > > > > > This addresses bug CLOUDSTACK-685. > > > > > > > > > > > > Diffs > > > > ----- > > > > > > > > > > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > > f6057e8 > > > > > > > > Diff: https://reviews.apache.org/r/11157/diff/ > > > > > > > > > > > > Testing > > > > ------- > > > > > > > > Testing ok. > > > > > > > > > > > > Thanks, > > > > > > > > Wei Zhou > > > > > > > > > > > > >
