----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8971/#review20595 -----------------------------------------------------------
Commit 8f7a51ee5f5d745026d51b9ca3b2746a39f00bf2 in branch refs/heads/master from Chip Childers <chip.child...@gmail.com> [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8f7a51e ] CLOUDSTACK-962: Because of the same reason to this (CLOUDSTACK-685) https://reviews.apache.org/r/11157/ Signed-off-by: Chip Childers <chip.child...@gmail.com> - ASF Subversion and Git Services On March 22, 2013, 9 a.m., Wei Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8971/ > ----------------------------------------------------------- > > (Updated March 22, 2013, 9 a.m.) > > > Review request for cloudstack, Kishan Kavala, Joe Brockmeier, and Rohit Yadav. > > > Description > ------- > > The usage sever does not handle data in the correct time. For example, it > regards the data traffic between 9:15-9:30 as the data traffic between > 9:30-9:45. > > If the interval is set to 1440(this means usge server calculate the data from > 0:00-23:59:59 at predefined time). The usage server regards the data traffic > between the server starting time(such as 13:00) to the next day(13:00) as the > data traffic between 0:00 an 23:59:59. > > Another problem is, when the usage.stats.job.aggregation.range is set to N( > for example, 15), the usage job handle the data every N+1 minutes( for > example 16). > > This is a patch for this issue (all details are described here: > https://issues.apache.org/jira/browse/CLOUDSTACK-962 ). > This patch depends on the patch for CLOUDSTACK-685 which is fixed in 4.0.1. > You can get from: > https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commit;h=2f1d83037bd4bb1165b378d6c1dfc2815f696681 > > > This addresses bug CLOUDSTACK-962. > > > Diffs > ----- > > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > 008c7c2 > server/src/com/cloud/user/dao/UserStatisticsDaoImpl.java fd7795a > usage/src/com/cloud/usage/UsageManagerImpl.java 53ebb14 > > Diff: https://reviews.apache.org/r/8971/diff/ > > > Testing > ------- > > The patch is tested in CloudStack Virtual Router environment (Advanced > Networking, not Basic Networking). > > usage.stats.job.aggregation.range = 5, the usage server collects data every > 10 minutes (such as collect data traffic between 13:00:00-13:10:00 at > 13:10:00). > usage.stats.job.aggregation.range = 15, the usage server collects data every > 15 minutes (such as collect data traffic between 13:00:00-13:15:00 at > 13:15:00). > usage.stats.job.aggregation.range = 60, the usage server collects data every > hour (such as collect data traffic between 13:00:00-14:00:00 at 14:10). > usage.stats.job.aggregation.range = 1440, the usage server collects data > every day (such as collect data traffic between 0:00:00-23:59:59 at 0:30). > > > Thanks, > > Wei Zhou > >
