----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11156/#review20636 -----------------------------------------------------------
Ship it! Ship It! - mice xia On May 14, 2013, 3:53 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11156/ > ----------------------------------------------------------- > > (Updated May 14, 2013, 3:53 p.m.) > > > Review request for cloudstack and mice xia. > > > Description > ------- > > When we call UpdateDefaultNicForVirtualMachine we should call appropriate > usage events as well for updating information related to default nic for > proper usage calculation. > Added 4 usage events : 2 for network.offerings.remove and 2 for > network.offerings.assign > Events are : network.offerings.assign for new nic to be made default, > network.offerings.remove for removal of non-default > network.offerings.assign for old default nic to be made non default and > network.offerings.remove for removal of default. > > > This addresses bug 2130. > > > Diffs > ----- > > server/src/com/cloud/vm/UserVmManagerImpl.java 0f6adc0 > > Diff: https://reviews.apache.org/r/11156/diff/ > > > Testing > ------- > > Tested manually. > Rat build passed. > Rebased to latest master. > > > Thanks, > > Saksham Srivastava > >
