I had written the test as per the old wiki page, now will refer to the new wiki and make the changes to the test. Thanks for the wiki example! If there is no objection, I will do these changes post-merge.
Thanks, Prachi -----Original Message----- From: Prasanna Santhanam [mailto:t...@apache.org] Sent: Wednesday, May 15, 2013 10:24 PM To: dev@cloudstack.apache.org Subject: Re: [MERGE] [CLOUDSTACK-2056] DeploymentPlanner choice via ServiceOffering If possible can you change the test to not use the API commands directly? I changed the affinity_groups test when that merge happened to make it use Resources as primary entities and not call API commands directly. I'm trying to switch marvin to use the Resource based approach [1] over API command based approach and would like to follow that as the norm. The command approach will be deprecated gradually. I rewrote the wiki [2] to include such an example which you can make use of and extend. [1] http://github.com/vogxn/docs/blob/master/MarvinRefactor.md [2] https://s.apache.org/ On Wed, May 15, 2013 at 10:36:33AM -0700, Prachi Damle wrote: > If there are no concerns, I will start merging these changes to master today. > > Thanks, > Prachi > > From: Prachi Damle [mailto:prachi.da...@citrix.com] > Sent: Friday, May 10, 2013 4:04 PM > To: dev@cloudstack.apache.org > Subject: [MERGE] [CLOUDSTACK-2056] DeploymentPlanner choice via > ServiceOffering > > Hi all, > > I would like to merge the feature [CLOUDSTACK-2056] developed in > planner_reserve branch to master. > > - Functional Specs: > https://cwiki.apache.org/confluence/display/CLOUDSTACK/DeploymentPlanner+choice+via+ServiceOffering > - Jira ticket: https://issues.apache.org/jira/browse/CLOUDSTACK-2056 > - Unit tests: Have added unit test under > cloud-server/test/com/cloud/vm/DeploymentPlanningManagerImplTest.java > - Integration tests: Added python test using marvin here: > cloud-testclient/integration/smoke/test_deploy_vms_with_varied_deploymentplanners.py > > I have rebased the branch with master Commit hash: > 19f014585e1d2a85b66ecd5ad57ee0c6338beb4c > Attached is the RAT report. > > Thanks, > -Prachi > -- Prasanna., ------------------------ Powered by BigRock.com
