----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11373/#review21060 -----------------------------------------------------------
server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java <https://reviews.apache.org/r/11373/#comment43564> Can offering.getVolatileVm() be null ? If yes then we should set false. - Nitin Mehta On May 24, 2013, 12:22 p.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11373/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 12:22 p.m.) > > > Review request for cloudstack and Koushik Das. > > > Description > ------- > > Missing isVolatile parameter in the response of service offering. > Need to add this in service offering response object. > > > This addresses bug CLOUDSTACK-2672. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/response/ServiceOfferingResponse.java > 08ebbb0 > server/src/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java ce20562 > server/src/com/cloud/api/query/vo/ServiceOfferingJoinVO.java 598e1d1 > setup/db/db/schema-410to420.sql 442a544 > > Diff: https://reviews.apache.org/r/11373/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Harikrishna Patnala > >
