----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11436/#review21082 -----------------------------------------------------------
api/src/com/cloud/agent/api/to/DnsmasqTO.java <https://reviews.apache.org/r/11436/#comment43608> nit: variable name shouldn't start with caps. Change in other places as well core/src/com/cloud/network/DnsMasqConfigurator.java <https://reviews.apache.org/r/11436/#comment43618> Can you format these text properly? What all is comment and what all actually gets replaced? core/src/com/cloud/network/DnsMasqConfigurator.java <https://reviews.apache.org/r/11436/#comment43617> What is the correct formatting here, tag:net1,6,... (used in the code below) OR dhcp-option=6,dns1,dns2,... server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java <https://reviews.apache.org/r/11436/#comment43619> You have the cidr which can be used as well in dhcp-range parameter. - Koushik Das On May 27, 2013, 3:05 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11436/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 3:05 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > [Multiple_IP_Ranges] Guest vm's nameserver is not set to VRs guest IP address > in case of multiple subnets > https://issues.apache.org/jira/browse/CLOUDSTACK-2620 > > > This addresses bug Cloudstack-2620. > > > Diffs > ----- > > api/src/com/cloud/agent/api/to/DnsmasqTO.java f99878c > core/src/com/cloud/network/DnsMasqConfigurator.java ee8e5fc > server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java > b969be2 > > Diff: https://reviews.apache.org/r/11436/diff/ > > > Testing > ------- > > tested on master. > > > Thanks, > > bharat kumar > >
