----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11462/#review21227 -----------------------------------------------------------
Rest of the patch looks fine save for the test_zwps module test/integration/smoke/test_zwps.py <https://reviews.apache.org/r/11462/#comment44081> This test is not required. If I deploy a zone with zone-wide storage then the regular deployVM test will be sufficient. - Prasanna Santhanam On May 28, 2013, 3:24 p.m., SrikanteswaraRao Talluri wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11462/ > ----------------------------------------------------------- > > (Updated May 28, 2013, 3:24 p.m.) > > > Review request for cloudstack, Prasanna Santhanam and Sateesh Chodapuneedi. > > > Description > ------- > > Added few basic zone wide primary storage tests. > > > This addresses bug CLOUDSTACK-2710. > > > Diffs > ----- > > test/integration/smoke/test_primary_storage.py 598654d > test/integration/smoke/test_zwps.py PRE-CREATION > tools/marvin/marvin/integration/lib/base.py ec1c34e > > Diff: https://reviews.apache.org/r/11462/diff/ > > > Testing > ------- > > done. > teardown() fails as there is a bug while moving a storagepool into > maintenance. > > > Thanks, > > SrikanteswaraRao Talluri > >
