----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11708/#review21570 -----------------------------------------------------------
server/src/com/cloud/api/ApiResponseHelper.java <https://reviews.apache.org/r/11708/#comment44617> How about using the StringUtils.join? It'll remove the need of appending the string together and them trimming it to remove the trailing separator. - Devdeep Singh On June 7, 2013, 10:36 a.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11708/ > ----------------------------------------------------------- > > (Updated June 7, 2013, 10:36 a.m.) > > > Review request for cloudstack and Devdeep Singh. > > > Description > ------- > > When multiple vlan ranges are added to a physical networks the vlan ranges > displayed in the output of the listPhysicalNetworks api displays the vlan > range in the order the ranges were added,Instead if they are displayed in the > ascending order range this would make it easy for the end user. > > > This addresses bug CLOUDSTACK-2167. > > > Diffs > ----- > > server/src/com/cloud/api/ApiResponseHelper.java bcc1605 > > Diff: https://reviews.apache.org/r/11708/diff/ > > > Testing > ------- > > The response of list api is now enhanced: > <listphysicalnetworksresponse cloud-stack-version="4.2.0-SNAPSHOT"> > <count>1</count> > <physicalnetwork> > <id>49e5cdfc-2c14-415a-9dd3-38ac2fdeef54</id> > <name>Physical Network 1</name> > <broadcastdomainrange>ZONE</broadcastdomainrange> > <zoneid>0bd17058-2931-479b-98b5-29c8c91c24d3</zoneid> > <state>Enabled</state> > <vlan>480-504;910-914;916-918;920-923;925-934;936-940</vlan> > <isolationmethods>VLAN</isolationmethods> > </physicalnetwork> > </listphysicalnetworksresponse> > Build passes successfully. > > > Thanks, > > Saksham Srivastava > >
