> On June 10, 2013, 4:23 p.m., Koushik Das wrote: > > Don't combine multiple fixes in a single commit. Keep it simple -> 1 commit > > = 1 bug fix
These issues are closely related to each other and so i think combining them is not bad - bharat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11600/#review21654 ----------------------------------------------------------- On June 4, 2013, 2:51 p.m., bharat kumar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11600/ > ----------------------------------------------------------- > > (Updated June 4, 2013, 2:51 p.m.) > > > Review request for cloudstack, Abhinandan Prateek and Koushik Das. > > > Description > ------- > > Cloudstack-2511 Multiple_Ip_Ranges: Adding guest ip range in subset/superset > to existing CIDR is allowed > https://issues.apache.org/jira/browse/CLOUDSTACK-2511 > > Cloudstack-2651 [Shared n/w]Add IP range should not ask for gateway and > netmask while adding the ip range to the existing subnet. > https://issues.apache.org/jira/browse/CLOUDSTACK-2651 > > > This addresses bugs Cloudstack-2511 and Cloudstack-2651. > > > Diffs > ----- > > server/src/com/cloud/configuration/ConfigurationManagerImpl.java 59e70cf > server/test/com/cloud/configuration/ValidateIpRangeTest.java 7681667 > utils/src/com/cloud/utils/net/NetUtils.java 8c094c8 > > Diff: https://reviews.apache.org/r/11600/diff/ > > > Testing > ------- > > Tested with master. > > > Thanks, > > bharat kumar > >
