Hiroaki,

- auto-fix may happen where it is really required
>
I do not have a clear view on this, so I took the approach of better safe
then sorry. The submitted is what works. I don't see how the auto-fix
should ever be needed if the source is fixed. Hope you can live with this.

> - and if auto-fix happens, it should log it with
> WARN level.

Applied


regards,


On Fri, Jun 14, 2013 at 10:35 AM, Daan Hoogland <daan.hoogl...@gmail.com>wrote:

> Thanks Hiroaki,
>
> On Fri, Jun 14, 2013 at 3:41 AM, Hiroaki KAWAI 
> <ka...@stratosphere.co.jp>wrote:
>
>> I'd suggest:
>> - fix the generation of double slash itself
>>
> Is in the patch
>
>> - auto-fix may happen where it is really required
>> - and if auto-fix happens, it should log it with
>> WARN level.
>
> Good point, I will up the level in an update.
>
>>
>>
>>
>> (2013/06/13 21:15), Daan Hoogland wrote:
>>
>>> H,
>>>
>>> Can someone look at Review Request #11861<https://reviews.apache.**
>>> org/r/11861/ <https://reviews.apache.org/r/11861/>> for me please?
>>>
>>> Thanks,
>>> Daan Hoogland
>>>
>>>
>>
>

Reply via email to