----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12200/#review22581 -----------------------------------------------------------
tools/marvin/marvin/deployDataCenter.py <https://reviews.apache.org/r/12200/#comment46297> Only 1 vmwareDC can be added to a zone, hence we don't need to iterate over vmwareDcs collection. Better if we have vmwareDc object rather than collection vmwareDcs. The above check for None is good. - Sateesh Chodapuneedi On June 30, 2013, 7:29 a.m., Rayees Namathponnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12200/ > ----------------------------------------------------------- > > (Updated June 30, 2013, 7:29 a.m.) > > > Review request for cloudstack, Girish Shilamkar and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Description > ------- > > Fixed issues while adding DC to zone in VM ware, > > Also script modified to skip adding host in vmware. > > > Diffs > ----- > > tools/marvin/marvin/deployDataCenter.py 961718a > > Diff: https://reviews.apache.org/r/12200/diff/ > > > Testing > ------- > > Tested > > > Thanks, > > Rayees Namathponnan > >
