Hari, The hypervisor comparison should be case insensitive. I think the types comes from a enum, can you also check the case there and try not to hardcode the hypervisor string. Another thing is that we are repeating the code for each Hypervisor this can be made more compact.
-abhi On 02/07/13 12:35 AM, "Alena Prokharchyk" <alena.prokharc...@citrix.com> wrote: >Ran sanity check for the 4.1-4.2 upgrade. Went fine with one exception - I >haven't pre-installed the 4.2 system templates, and the update didn't >fail. > >Hari, can you please fix it as you were the one who implemented system >template upgrade. Steps to reproduce: > >1) Istall 4.1.0 >2) Add 1 xen cluster with 1 host and 1 primary storage. > >mysql> select distinct(hypervisor_type) from `cloud`.`cluster` where >removed is null; >+-----------------+ >| hypervisor_type | >+-----------------+ >| xenserver | >+-----------------+ > > > >3) Upgrade to 4.2 > >I bet all you have to do is to fix string comparison in >Upgrade410to42.java > >-alena. > >
