----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11984/ -----------------------------------------------------------
(Updated July 2, 2013, 11:09 p.m.) Review request for cloudstack, Chip Childers, edison su, and Min Chen. Changes ------- Uploading new diff incorporating Edison's review comments. Bugs: CLOUDSTACK-1510 Repository: cloudstack-git Description ------- Patch for fixes for issues detected while working on bug CLOUDSTACK-1510 (https://issues.apache.org/jira/browse/CLOUDSTACK-1510). Diffs (updated) ----- api/src/org/apache/cloudstack/api/command/admin/storage/CreateStoragePoolCmd.java f5750b9 plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java 89e22c8 plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java 2e0ff66 server/src/com/cloud/storage/StorageManagerImpl.java bb21afb Diff: https://reviews.apache.org/r/11984/diff/ Testing ------- Deploy KVM cluster in cloudstack. Attempt to add a primary NFS datastore using an invalid path. NPE is not encountered anymore. If KVM host is down or the cloud-agent on the KVM host is down, the primary datastore (whether valid or otherwise) is not logged to the db's storage_pool table. So invalid datastores do not show up in the GUI when listing the primary datastores available. Also, exception is propagated to GUI. Thanks, Venkata Siva Vijayendra Bhamidipati
