----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12264/#review22759 -----------------------------------------------------------
Since we have already put it to be case insensitive will this be causing issues for upgrade or anywhere else we are comparing. This is concerning - Nitin Mehta On July 4, 2013, 8:40 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12264/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 8:40 a.m.) > > > Review request for cloudstack and Abhinandan Prateek. > > > Bugs: CLOUDSTACK-3351 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3351: Fix add cluster API to set right hypervisor type > In AddCluster API we validate Hypervisor type parameter even if it is case > insensitive. We should not put this case insensitive value in the DB which > may lead to mismatch with hypervisor type with other tables in DB leading to > failure of various DB queries. > > > Diffs > ----- > > server/src/com/cloud/resource/ResourceManagerImpl.java c6e8d7d > > Diff: https://reviews.apache.org/r/12264/diff/ > > > Testing > ------- > > > Thanks, > > Harikrishna Patnala > >
