----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12227/#review22846 -----------------------------------------------------------
Ship it! Fix looks good. - Venkata Siva Vijayendra Bhamidipati On July 4, 2013, 12:32 p.m., Rajesh Battala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12227/ > ----------------------------------------------------------- > > (Updated July 4, 2013, 12:32 p.m.) > > > Review request for cloudstack, edison su, Ram Ganesh, and Sateesh > Chodapuneedi. > > > Bugs: 3301 > > > Repository: cloudstack-git > > > Description > ------- > > Issue: > When VM is getting deployed in ZWPS(kvm, vmware), NPE is occuring. > > Fixed: > SolidFire storage had introduced iops, its setting capacityIops on the pool > level. Only solidfire is setting and getting it which is causing NPE when > checking this value for other type PS. > This fixed will resolve the issue for any storage provider which don't set > capacityIops. > > > Diffs > ----- > > server/src/com/cloud/storage/StorageManagerImpl.java bb21afb > > Diff: https://reviews.apache.org/r/12227/diff/ > > > Testing > ------- > > 1. Adding ZWPS, and deployed the VM in KVM. Vm got successfully deployed. > 2. Adding CWPS and deployed the VM in KVM. VM got deployed successfully. > > > Thanks, > > Rajesh Battala > >