----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12273/ -----------------------------------------------------------
(Updated July 10, 2013, 5:43 p.m.) Review request for cloudstack and Abhinandan Prateek. Changes ------- updated and rebased the code with master-stable Bugs: Cloudstack-2150 and Cloudstack-2980 Repository: cloudstack-git Description ------- Cloudstack-2150 DB table entries of phisical network is not proper.Shows Duplicate entries Cloudstack-2980 Adding a VLAN range that overlaps with two existing ranges results inconsistent DB entries This fix was causing a regression due to which the state of the physical network was not getting updated and as a result basic zone deployment failed. Resubmitting the fixed code. Diffs (updated) ----- engine/schema/src/com/cloud/dc/dao/DataCenterDao.java ed6e696 engine/schema/src/com/cloud/dc/dao/DataCenterDaoImpl.java 503306f engine/schema/src/com/cloud/dc/dao/DataCenterVnetDao.java 778498d engine/schema/src/com/cloud/dc/dao/DataCenterVnetDaoImpl.java e97f2c6 server/src/com/cloud/network/NetworkServiceImpl.java 49bfb88 server/test/com/cloud/network/UpdatePhysicalNetworkTest.java 25c023e Diff: https://reviews.apache.org/r/12273/diff/ Testing ------- Tested basic zone deployment. adding vlan removing vlan removing all vlan checked if all the added vlans are in the db. Thanks, bharat kumar
