Cool. +1 then On Jul 11, 2013, at 9:28 PM, David Nalley <da...@gnsa.us> wrote:
> I was worried about the same thing, but ran build_asf.sh to create a > tarball and then built it. > > Here's the resulting output, which isn't perfectly nice, but also isn't > broken. > > ke4qqq@mba ~/apache-cloudstack-4.2.0-RC2-src/client/target/META-INF[master*]$ > cat MANIFEST.MF > Manifest-Version: 1.0 > Implementation-Vendor: The Apache Software Foundation > Implementation-Title: Apache CloudStack Client UI > Implementation-Version: 4.2.0-RC2 > Implementation-Revision: UNKNOWN_REVISION > Implementation-Vendor-Id: org.apache.cloudstack > Built-By: ke4qqq > Build-Jdk: 1.7.0_09-icedtea > Created-By: Apache Maven 3.0.4 > Implementation-Branch: UNKNOWN_BRANCH > Archiver-Version: Plexus Archiver > > --David > > On Thu, Jul 11, 2013 at 9:01 PM, Chip Childers > <chip.child...@sungard.com> wrote: >> Is it off by default? >> >> Our releases aren't from git. >> >> On Jul 11, 2013, at 8:38 PM, Alex Huang <alex.hu...@citrix.com> wrote: >> >>> Hi All, >>> >>> I added the branch and git commit id to the war file. You can find it by >>> opening the war file and retrieving the META-INF/MANIFEST.MF. Inside, >>> there is a Implementation-Revision which contains the git commit id and a >>> Implementation-Branch which contains the branch. >>> >>> We should add these to all of our jira issues so developers can easily >>> figure out the revision being tested and work appropriately. >>> >>> I will also cherry-pick this to 4.2. I assume there's no objections. >>> >>> --Alex >>> >