> On July 12, 2013, 6:32 a.m., Prasanna Santhanam wrote: > > This test was moved to a separate suite : test_shared_network_offering.py > > > > Girish Shilamkar wrote: > Was it just moved or it was changed to. Cause in any case without ip > range shared network cannot be created.
Moved. So your patch failed to apply as a result. Can you resubmit? - Prasanna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12497/#review23063 ----------------------------------------------------------- On July 12, 2013, 6:15 a.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12497/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 6:15 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-3340 > > > Repository: cloudstack-git > > > Description > ------- > > > CLOUDSTACK-3340: Removed a test which was invalid. > > test_deployVmSharedNetworkWithoutIpRange is invalid because > StartIp/endIp/gateway/netmask are required parameters > when shared network is created. > > > Diffs > ----- > > test/integration/component/test_network_offering.py a3e87f6 > > Diff: https://reviews.apache.org/r/12497/diff/ > > > Testing > ------- > > > Thanks, > > Girish Shilamkar > >
