----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12504/#review23078 -----------------------------------------------------------
Ship it! Looks good to me - Kishan Kavala On July 12, 2013, 4:26 p.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12504/ > ----------------------------------------------------------- > > (Updated July 12, 2013, 4:26 p.m.) > > > Review request for cloudstack and Kishan Kavala. > > > Bugs: CLOUDSTACK-2757 > > > Repository: cloudstack-git > > > Description > ------- > > Category is not being persisted when configuration items are added in > ConfigurationDaoImpl.getValueAndInitIfNotExist. > Hence it will be set to 'Advanced' which is the default which will lead to > encryption failures if encryption is enabled. > Also cleaned up the code to use VO/DAO instead of SQL. > > > Diffs > ----- > > engine/schema/src/com/cloud/configuration/dao/ConfigurationDaoImpl.java > fe5f5ae > > Diff: https://reviews.apache.org/r/12504/diff/ > > > Testing > ------- > > > Thanks, > > Likitha Shetty > >
