----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12510/ -----------------------------------------------------------
Review request for cloudstack, Alena Prokharchyk and Devdeep Singh. Bugs: 3476 Repository: cloudstack-git Description ------- In case the release dedicate resource fails, deletion of domain should not happen. Whenever deleting a domain all the resources dedicated to it must be released of dedication and moved to shared pool. Currently even if release API fails the deleteDomain API is executed successfully. Further if there are dedicated resources to a domiain and cleanup is not true, resources should not be released. Added checks to prohibit this behaviour. Diffs ----- server/src/com/cloud/user/DomainManagerImpl.java aad5787 Diff: https://reviews.apache.org/r/12510/diff/ Testing ------- If domain has dedicated resources, cleanup=true will release dedication and delete the domain. cleanup=false will not release dedication and will not delete the domain. Thanks, Saksham Srivastava
