----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12348/#review23107 -----------------------------------------------------------
Ship it! Ship It! - edison su On July 9, 2013, 10:15 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12348/ > ----------------------------------------------------------- > > (Updated July 9, 2013, 10:15 p.m.) > > > Review request for cloudstack, Chip Childers, Kelven Yang, rajeshbabu > chintaguntla, and Sateesh Chodapuneedi. > > > Bugs: CLOUDSTACK-3264 > > > Repository: cloudstack-git > > > Description > ------- > > When listing zone wide primary storages for volume migration, a null pointer > exception is encountered because the listing of the eligible storage pools > missed taking into account the absence of cluster id for zone wide primary > pools. Fixing the same and putting in appropriate checks for other storage > type allocators. > > Note: This fix is for the master-6-17-stable branch. It is to be seen whether > this fix is required for master and if so, needs to be ported/tested on the > same. > > > Diffs > ----- > > > engine/storage/src/org/apache/cloudstack/storage/allocator/AbstractStoragePoolAllocator.java > e16703e > > engine/storage/src/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java > 0933adc > > engine/storage/src/org/apache/cloudstack/storage/allocator/LocalStoragePoolAllocator.java > ef9e84e > > plugins/storage-allocators/random/src/org/apache/cloudstack/storage/allocator/RandomStoragePoolAllocator.java > 76ce663 > server/src/com/cloud/server/ManagementServerImpl.java da9d6a2 > > Diff: https://reviews.apache.org/r/12348/diff/ > > > Testing > ------- > > Created multiple zone wide primary storages and confirmed that they show up > as eligible destinations when attempting to migrate a volume currently > resident on a zone wide primary storage pool. Created mixed zone-wide and > cluster-wide primary storages to ensure nothing broke there. Observed that > volumes on a zone wide primary can only be moved to other zone wide primary > pools and similarly with cluster wide pools. Created new guest VM to confirm > that existing primary code paths work correctly with the changes in place. > > > Thanks, > > Venkata Siva Vijayendra Bhamidipati > >
