----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12591/#review23222 -----------------------------------------------------------
Ship it! Ship It! - edison su On July 16, 2013, 10:37 p.m., Fang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12591/ > ----------------------------------------------------------- > > (Updated July 16, 2013, 10:37 p.m.) > > > Review request for cloudstack and edison su. > > > Bugs: CLOUDSTACK-3566 > > > Repository: cloudstack-git > > > Description > ------- > > The return value verification in the script is wrong, causing the code path > to go to wrong branch. > This affects snapshot backup for KVM host. > > > Diffs > ----- > > scripts/storage/qcow2/managesnapshot.sh 30148de > > Diff: https://reviews.apache.org/r/12591/diff/ > > > Testing > ------- > > tested a snapshot created, and it got successfully backedup after the fix. > > > Thanks, > > Fang Wang > >
