----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12358/#review23238 -----------------------------------------------------------
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java <https://reviews.apache.org/r/12358/#comment47125> you are logging warn n checing debug enabled ? Dont have to check that server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java <https://reviews.apache.org/r/12358/#comment47129> Ideally, I would have liked it to be a separate function like getReadySystemTemplate(zoneId) Also this should be a SQL query rather than embedding logic in Java server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java <https://reviews.apache.org/r/12358/#comment47126> log it in warn server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java <https://reviews.apache.org/r/12358/#comment47128> In logs try to put in as much information. Put zone id and list of hypervisors you tried. server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java <https://reviews.apache.org/r/12358/#comment47130> Boiler plate code. - Nitin Mehta On July 10, 2013, 10:56 a.m., Harikrishna Patnala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12358/ > ----------------------------------------------------------- > > (Updated July 10, 2013, 10:56 a.m.) > > > Review request for cloudstack and Nitin Mehta. > > > Bugs: CLOUDSTACK-3228 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-3228: system vms are not comming up in zone with two cluster xen > and kvm;Zone host is ready, but secondary storage vm template: 3 is not ready > on secondary storage: 2 > > Shuffling the hypervisors list before getting the first hypervisor in list so > that on every retry of system vm deployment it chooses different hypervisor > and checking whether template is downloaded or not. > > > Diffs > ----- > > engine/schema/src/com/cloud/storage/dao/VMTemplateDaoImpl.java 9e75990 > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java > 407f069 > server/src/com/cloud/consoleproxy/ConsoleProxyManagerImpl.java 5983aa7 > server/src/com/cloud/resource/ResourceManager.java e35e89a > server/src/com/cloud/resource/ResourceManagerImpl.java 41c6ad7 > server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java > 05256a8 > server/test/com/cloud/resource/MockResourceManagerImpl.java 18cff80 > > Diff: https://reviews.apache.org/r/12358/diff/ > > > Testing > ------- > > tested locally > > > Thanks, > > Harikrishna Patnala > >
