----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12427/ -----------------------------------------------------------
(Updated July 17, 2013, 7:37 a.m.) Review request for cloudstack, Abhinandan Prateek, Koushik Das, and Nitin Mehta. Changes ------- Updated patch based on review comments Bugs: CLOUDSTACK-2536 and CLOUDSTACK-3365 Repository: cloudstack-git Description ------- CLOUDSTACK-3365: cluster level parameters cluster.(cpu/memory).allocated.capacity.notificationthreshold is not considering overcommit value CLOUDSTACK-2536: parameters (cpu/memory)overcommit ratio and (cpu/memory).overprosioning.factor are redundant(cluster level) Diffs (updated) ----- server/src/com/cloud/alert/AlertManagerImpl.java 9b7cd27 server/src/com/cloud/configuration/Config.java e77f6ce server/src/com/cloud/vm/VirtualMachineManagerImpl.java 827e233 server/test/com/cloud/vm/VirtualMachineManagerImplTest.java 44e22e2 Diff: https://reviews.apache.org/r/12427/diff/ Testing ------- Tested locally both with actual usage and over committed values for memory. Thanks, Harikrishna Patnala