> On July 19, 2013, 9:41 a.m., Wido den Hollander wrote: > > It seems good to me? Code-wise I can't find anything that isn't right. > > > > I see that Spark404 is also mentioned here, did he get a chance to look at > > this yet?
Yeah, i'm ok with this. I'm actually abusing this patch to test jenkins-reviewboard integration, thats why i haven't committed it. - Hugo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12685/#review23493 ----------------------------------------------------------- On July 17, 2013, 3:46 p.m., daan Hoogland wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12685/ > ----------------------------------------------------------- > > (Updated July 17, 2013, 3:46 p.m.) > > > Review request for cloudstack and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1532 > > > Repository: cloudstack-git > > > Description > ------- > > the review for the complete patch was open to long and no longer applicable, > so I am starting with smaller patches as this is really needed to implement > CLOUDSTACK-1532 > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java 5aede05 > api/test/com/cloud/network/NetworksTest.java PRE-CREATION > > Diff: https://reviews.apache.org/r/12685/diff/ > > > Testing > ------- > > unit testing > > > Thanks, > > daan Hoogland > >
