----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12222/#review23501 -----------------------------------------------------------
Ship it! Ship It! - Devdeep Singh On July 2, 2013, 5:26 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12222/ > ----------------------------------------------------------- > > (Updated July 2, 2013, 5:26 a.m.) > > > Review request for cloudstack, Devdeep Singh, edison su, and Nitin Mehta. > > > Bugs: CLOUDSTACK-2510 > > > Repository: cloudstack-git > > > Description > ------- > > CLOUDSTACK-2510: Getting NPE while executinng listStoragePools API command. > > Tried to add a primary storage to empty xen cluster; after this event not > able to list primary storage, getting NPE . > > > Diffs > ----- > > > plugins/storage/volume/default/src/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java > 2e0ff66 > > Diff: https://reviews.apache.org/r/12222/diff/ > > > Testing > ------- > > Tests: > 1. Add an empty cluster (without any host). > 2. Add a cluster wide primary storage to this cluster (It will fail with an > exception that "Fail to add data store"). > 3. Verified that listStoragePools API is working properly and its not listing > the storage pool that admin tried to add in step 2. > > > Thanks, > > Sanjay Tripathi > >
