----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/#review23610 -----------------------------------------------------------
Commit 7260e8d83f07d90b48c34adaeb227de265019487 in branch refs/heads/pvlan from Hiroaki Kawai [ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7260e8d ] CLOUDSTACK-1638: Introduce NetworkMigrationResponder The location of the virtual machine is provided by DeployDestination, which will be passed in NetworkGuru#reserve and NetworkElement#prepare. During the virtual machine migration, it actually changes DeployDestination and it looks like that it will tell that event to network components as it has NetworkManager#prepareNicForMigration. The problem is that althogh the interface has that method, NetworkManagerImpl does not tell the DeployDestination changes to network components. So IMHO, we need to add calls of NetworkGuru#reserve and NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And then, we also need to add calls NetworkGuru#release and NetworkElement#release after the migration, otherwise the network resources that plugin reserved will be kept even when the vm leaves off. (Sheng Yang: rebase code, add license header) Signed-off-by: Sheng Yang <sheng.y...@citrix.com> - ASF Subversion and Git Services On April 11, 2013, 7:22 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9871/ > ----------------------------------------------------------- > > (Updated April 11, 2013, 7:22 a.m.) > > > Review request for cloudstack, Chiradeep Vittal and Hugo Trippaers. > > > Bugs: CLOUDSTACK-1638 > > > Repository: cloudstack-git > > > Description > ------- > > The location of the virtual machine is provided by DeployDestination, which > will be passed in NetworkGuru#reserve and NetworkElement#prepare. > > During the virtual machine migration, it actually changes DeployDestination > and it looks like that it will tell that event to network components as it > has NetworkManager#prepareNicForMigration. The problem is that althogh the > interface has that method, NetworkManagerImpl does not tell the > DeployDestination changes to network components. > > So IMHO, we need to add calls of NetworkGuru#reserve and > NetworkElement#prepare in NetworkManagerImpl#prepareNicForMigration . And > then, we also need to add calls NetworkGuru#release and > NetworkElement#release after the migration, otherwise the network resources > that plugin reserved will be kept even when the vm leaves off. > > Created a first minimum patch to show the concept. > > > Diffs > ----- > > api/src/com/cloud/network/NetworkMigrationResponder.java PRE-CREATION > server/src/com/cloud/network/NetworkManager.java 4124b19 > server/src/com/cloud/network/NetworkManagerImpl.java a98bdd4 > server/src/com/cloud/vm/VirtualMachineManagerImpl.java 9230f4a > > Diff: https://reviews.apache.org/r/9871/diff/ > > > Testing > ------- > > > Thanks, > > Hiroaki Kawai > >