Hi, I'd like to request a patch for Cloudstack-2188 for ACS 4.1.1.
The master commit was e56d2a401c40b4208d062c0a0ce1ec01df73dd08, but it appears the code has been greatly re-factored since 4.1 was originally branched. This NPE appears to be causing a memory leak in our production environment that consumes memory quickly due to the number of times this NPE is being triggered. We currently have tomcat max memory set to 2G, and individual management servers are running out of memory within 4 to 5 days. MS NPE log for reference: 2013-07-22 09:40:47,404 DEBUG [agent.manager.AgentManagerImpl] (AgentConnectTaskPool-1066:null) Details from executing class com.cloud.agent.api.storage.ListVolumeCommand: success 2013-07-22 09:40:47,407 ERROR [agent.manager.AgentManagerImpl] (AgentConnectTaskPool-1066:null) Monitor DownloadListener says there is an error in the connect process for 28 due to null java.lang.NullPointerException at com.cloud.storage.download.DownloadMonitorImpl.handleVolumeSync(DownloadMonitorImpl.java:694) at com.cloud.storage.download.DownloadMonitorImpl.handleSync(DownloadMonitorImpl.java:620) at com.cloud.storage.download.DownloadListener.processConnect(DownloadListener.java:385) at com.cloud.agent.manager.AgentManagerImpl.notifyMonitorsOfConnection(AgentManagerImpl.java:611) at com.cloud.agent.manager.AgentManagerImpl.handleConnectedAgent(AgentManagerImpl.java:1111) at com.cloud.agent.manager.AgentManagerImpl.access$100(AgentManagerImpl.java:145) at com.cloud.agent.manager.AgentManagerImpl$HandleAgentConnectTask.run(AgentManagerImpl.java:1186) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1146) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:679) Thanks, - Si
