-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12853/
-----------------------------------------------------------
(Updated July 23, 2013, 12:34 p.m.)
Review request for cloudstack, Alena Prokharchyk, Devdeep Singh, and Prasanna
Santhanam.
Changes
-------
Change to test is fine. Not sure about the DomainManager change. Adding Alena
as reviewer.
Bugs: CLOUDSTACK-3688
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3688: Test cases
test_accounts.TestDomainForceRemove.test_forceDeleteDomain, not found the
domain to delete and failed.
This issue is in CS product and not in the test_script.
The problem is coming because in case of deleteDomain with cleanup = true,
CS is not allowing deletion of domain if there are any account under that
domain needs clean up; though these accounts are removed and admin can't
see them in the listaccounts.
So CS should not restrict the deleteDomain in case of accounts needs
cleanup.
Diffs
-----
server/src/com/cloud/user/DomainManagerImpl.java 1117ff0
test/integration/component/test_accounts.py 3c284bd
Diff: https://reviews.apache.org/r/12853/diff/
Testing
-------
Verified marvin test on my local cloudstack setup.
Thanks,
Sanjay Tripathi
