----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12810/ -----------------------------------------------------------
(Updated July 24, 2013, 10:28 a.m.) Review request for cloudstack, Alena Prokharchyk and Sheng Yang. Changes ------- Fixed the issues pointed out in the review. Also added a fix to handle vms with multiple nics. Bugs: CLOUDSTACK-3694 Repository: cloudstack-git Description ------- https://issues.apache.org/jira/browse/CLOUDSTACK-3694 wrote the dnsmasq config in bash instead of creating the config file in java and overwriting. Diffs (updated) ----- core/src/com/cloud/agent/api/routing/DnsMasqConfigCommand.java 521ad70 core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java 0b26220 core/src/com/cloud/network/DnsMasqConfigurator.java 3fc61df patches/systemvm/debian/config/etc/init.d/cloud-early-config c04ff90 patches/systemvm/debian/config/root/dnsmasq.sh b70e2d3 plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java c7f487e plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java f80d4b6 scripts/vm/hypervisor/xenserver/vmops f8c0253 server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java 6c0f7a1 server/src/com/cloud/vm/VirtualMachineManagerImpl.java 7a4bf50 Diff: https://reviews.apache.org/r/12810/diff/ Testing ------- Tested on old master using xenserver. Could not test on the latest one as it is broken. Thanks, bharat kumar