rohityadavcloud commented on code in PR #107:
URL: https://github.com/apache/cloudstack-go/pull/107#discussion_r2046235561
##########
generate/generate.go:
##########
@@ -560,7 +560,7 @@ func (as *allServices) GeneralCode() ([]byte, error) {
pn("// Execute the request against a CS API. Will return the raw JSON
data returned by the API and nil if")
pn("// no error occurred. If the API returns an error the result will
be nil and the HTTP error code and CS")
pn("// error details. If a processing (code) error occurs the result
will be nil and the generated error")
- pn("func (cs *CloudStackClient) newRequest(api string, params
url.Values) (json.RawMessage, error) {")
+ pn("func (cs *CloudStackClient) newPostRequest(api string, params
url.Values) (json.RawMessage, error) {")
Review Comment:
@kevin-lii should all API calls be POST by default? Or, we should compare if
it's a list/get API ?
cc @Pearl1594 @weizhouapache @sureshanaparti @vishesh92
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
