Copilot commented on code in PR #538:
URL:
https://github.com/apache/cloudstack-documentation/pull/538#discussion_r2276662371
##########
source/adminguide/service_offerings.rst:
##########
@@ -304,7 +304,9 @@ To create a new compute offering:
This is applicable only for KVM hypervisor.
- **GPU Display**: Whether to use the GPU device attached to the guest
instance for display.
- This is applicable only for KVM hypervisor.
+ This is applicable only for KVM hypervisor. Depending on the OS and
display configuration,
+ the user might need to set ``video.hardware`` to ``none`` in the
instance's settings to
+ use CPVM for display.
Review Comment:
The documentation should clarify where exactly the instance settings are
located and how to access them. Consider adding the specific path or UI
location where users can modify the `video.hardware` setting.
```suggestion
use CPVM for display. To modify the ``video.hardware`` setting,
navigate to the instance's details page in the CloudStack UI, click on the
"Settings" tab, and locate the ``video.hardware`` option to change its value.
```
##########
source/adminguide/hosts.rst:
##########
@@ -243,10 +243,34 @@ the host.
The cloudstack agent uses the ``gpudiscovery.sh`` script to discover the GPU
devices on a KVM host. The script is located in the
-``/usr/share/cloudstack-common/scripts/vm/`` directory on the host.
+``/usr/share/cloudstack-common/scripts/vm/`` directory on the host. The script
+relies on the ``lspci`` & ``xmlstarlet`` command to discover the GPU devices
+and their status on the host. So, for the discovery to be successful, the
+``lspci`` & ``xmlstarlet`` commands needs to be installed on the host.
Review Comment:
Subject-verb disagreement: 'commands needs' should be 'commands need'
(plural subject requires plural verb).
```suggestion
``lspci`` & ``xmlstarlet`` commands need to be installed on the host.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
