> On July 25, 2013, 4:09 p.m., Wido den Hollander wrote: > > Seems good to me!
Wido, Rajesh if the patch is good please commit and help close the issue - Animesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12943/#review23852 ----------------------------------------------------------- On July 25, 2013, 2:01 p.m., Rene Diepstraten wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12943/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 2:01 p.m.) > > > Review request for cloudstack and Wido den Hollander. > > > Repository: cloudstack-git > > > Description > ------- > > In scripts/vm/network/security_group.py, external calls to virsh are made. > Python has a module python-libvirt which has native libvirt bindings. > This patch replaces the external calls to the virsh command with functions > that use the native python implementation. > > > Diffs > ----- > > debian/control 46dd505 > packaging/centos63/cloud.spec 61e00bd > scripts/vm/network/security_group.py 2ce558f > > Diff: https://reviews.apache.org/r/12943/diff/ > > > Testing > ------- > > Tested the output of the new functions. This should be the same as the virsh > command. > > > Thanks, > > Rene Diepstraten > >
