vishesh92 commented on code in PR #206:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/206#discussion_r2303572507


##########
cloudstack/resource_cloudstack_network_offering.go:
##########
@@ -125,34 +125,34 @@ func resourceCloudStackNetworkOfferingUpdate(d 
*schema.ResourceData, meta interf
 
        }
 
-       // Check if the guest ip type is changed and if so, update the virtual 
machine
-       if d.HasChange("guest_ip_type") {
-               log.Printf("[DEBUG] Guest ip type changed for %s, starting 
update", name)
+       // Check if maxconnections is changed and if so, update the network 
offering

Review Comment:
   These fields are not defined in the schema. Let's merge this PR with 
https://github.com/apache/cloudstack-terraform-provider/pull/205/?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to