sidshas03 commented on PR #219: URL: https://github.com/apache/cloudstack-terraform-provider/pull/219#issuecomment-3298488703
Hi @DaanHoogland & @kiranchavala, Just putting down the commit history clearly so you both know what happened and why: - First I added the unit tests for L2/L3 validation (e9b39ff). CI failed there because I had missed adding the Apache license headers. - Then I did some formatting fixes (46944cc). - After that there was a mistake commit which removed the test files (7676559). That was not correct, so I dropped it. - Latest commit (440ec8c) adds the proper Apache 2.0 license headers to the test files and keeps everything intact. - Now the branch has the tests intact, formatting is proper, and the license headers are in place. - Once you approver run, I’ll handle any CI failures with only safe fixes (no test deletions, no schema or validation changes). Thanks for the reviews so far. Requesting you to please review the workflows when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
