sidshas03 commented on PR #218:
URL: 
https://github.com/apache/cloudstack-terraform-provider/pull/218#issuecomment-3338699088

   CI is currently failing at the `fmtcheck` gate (gofmt), so tests never run. 
I’ve pushed `make fmt` fixes.
   Functionally, the failing checks were due to the `ports` attribute remaining 
in state for “all-ports” rules. I’ve updated both Create and Read to omit 
`ports` entirely (via `delete(rule, "ports")`) and added read-side 
normalization for API representations of all-ports (`1–65535` and `-1/-1`). 
This aligns with the existing tests that assert `NoResourceAttr(..., 
"rule.0.ports")`. Once formatting passes, the acceptance tests should exercise 
this behavior. I’ll watch the matrix and address anything else that comes up.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to