----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12968/#review24049 -----------------------------------------------------------
server/src/com/cloud/template/HypervisorTemplateAdapter.java <https://reviews.apache.org/r/12968/#comment47877> How can you guarantee that listSrcTmpltStore.get(0) is the entry you desire? You should find that exact (templateId, storeId) entry by passing both templateId and storeId, which should be able to be obtained from template.getDataStore().getId(). server/src/com/cloud/template/HypervisorTemplateAdapter.java <https://reviews.apache.org/r/12968/#comment47875> Why cannot you provide a method in UsageEventDao to search by template id and event type? This way, you don't need to find a bigger set and filter here by looping. server/src/com/cloud/template/HypervisorTemplateAdapter.java <https://reviews.apache.org/r/12968/#comment47874> This is not right. For cross-zone template, in HypervisorTemplateAdapter.create(TemplateProfile) method, you will see that there is a for-loop to download the template to each image store for each zone. For each image store, this createTemplateAsyncCallback will be invoked. So in this callback, you should just generate usage event for this zone. - Min Chen On July 27, 2013, 6:58 p.m., Saksham Srivastava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12968/ > ----------------------------------------------------------- > > (Updated July 27, 2013, 6:58 p.m.) > > > Review request for cloudstack and Min Chen. > > > Bugs: 3686 > > > Repository: cloudstack-git > > > Description > ------- > > Registering a template does not generate a usage event. > The process should generate a usage event when the template is 100% > downloaded. > Added a new usage event that has virtual_size also as a parameter. > > > Diffs > ----- > > engine/schema/src/com/cloud/event/dao/UsageEventDao.java 01979e1 > engine/schema/src/com/cloud/event/dao/UsageEventDaoImpl.java cda02ef > server/src/com/cloud/template/HypervisorTemplateAdapter.java 4b3cade > > Diff: https://reviews.apache.org/r/12968/diff/ > > > Testing > ------- > > Now usage_event table is getting updated with the new usage_event. > > select * from usage_event where id = 23; > +----+-----------------+------------+---------------------+---------+-------------+---------------+-------------+-------------+----------+---------------+-----------+--------------+ > | id | type | account_id | created | zone_id | > resource_id | resource_name | offering_id | template_id | size | > resource_type | processed | virtual_size | > +----+-----------------+------------+---------------------+---------+-------------+---------------+-------------+-------------+----------+---------------+-----------+--------------+ > | 23 | TEMPLATE.CREATE | 2 | 2013-07-26 12:04:29 | 0 | > 215 | r8 | NULL | NULL | 16777728 | NULL | > 0 | 16777216 | > +----+-----------------+------------+---------------------+---------+-------------+---------------+-------------+-------------+----------+---------------+-----------+--------------+ > > > Build passed. > Patch applies cleanly. > > > Thanks, > > Saksham Srivastava > >
