> On July 29, 2013, 4:35 a.m., Prasanna Santhanam wrote: > > test/integration/component/test_netscaler_nw_off.py, line 613 > > <https://reviews.apache.org/r/13009/diff/1/?file=330048#file330048line613> > > > > I think you should remove the ntwk offering altogether from cleanup. > > > > Network offerings currently do not delete if the account's network > > deployed from that offering isn't shutdown in time. Since offerings are > > lightweight and do not consume physical/virtual resources, we should defer > > them from the cleanup process.
Reason to wait on cleanup in this test is to remove the Netscaler devices added as part of the test. Those could be used for other tests. To remove the device, we need to wait on clean up of the networks as well. So we aren't really waiting on network offering cleanup. - Sowmya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13009/#review24082 ----------------------------------------------------------- On July 29, 2013, 4:12 a.m., Sowmya Krishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13009/ > ----------------------------------------------------------- > > (Updated July 29, 2013, 4:12 a.m.) > > > Review request for cloudstack and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-3744 > > > Repository: cloudstack-git > > > Description > ------- > > Fix for CLOUDSTACK-3744. Order of cleanup of objects fixed. > > > Diffs > ----- > > test/integration/component/test_netscaler_nw_off.py 5fd2195 > > Diff: https://reviews.apache.org/r/13009/diff/ > > > Testing > ------- > > Tested locally. Script is now passing and cleanup of all accounts done. > > > Thanks, > > Sowmya Krishnan > >
