> On July 29, 2013, 8:30 a.m., daan Hoogland wrote: > > Jijun, please make sure your adjusted call to URI() only gets called when > > BroadcastDomainType is Vlan, Storage or Mido and not when it is for > > instance Lswitch.
when scheme is vlan, some code will invoke URI.getHost(), but it will return null, and should be vlan id. in fact , it is the issue of IsolationType. but i find BroadcastDomainType has the same logic,so i change it too. maybe i should check the scheme in function toURI(). - Jijun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13004/#review24098 ----------------------------------------------------------- On July 28, 2013, 11:49 a.m., Jijun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13004/ > ----------------------------------------------------------- > > (Updated July 28, 2013, 11:49 a.m.) > > > Review request for cloudstack, edison su and Wei Zhou. > > > Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-3883 > > > Repository: cloudstack-git > > > Description > ------- > > In lastest CS 4.2 code, I create advance zone with hypervisor vmware esxi, > create public Network with vlan id 509 specified and label vSwitch0, when cs > create systemvm(cpvm,ssvm), > a new portgroup with name cloud.public.untagged.0.1-vSwitch0 was created, > not a portgroup cloud.public.509.0.1-vSwitch0 as expected. > in database table nics, the field broadcast_uri for new systemvm is vlan:509 > , and should be vlan://509 > debug the code and found it is a syntax error in Networks.java for new > instance java.net.URI. > > > Diffs > ----- > > api/src/com/cloud/network/Networks.java c76c3d4 > > Diff: https://reviews.apache.org/r/13004/diff/ > > > Testing > ------- > > recreate the system vm or create a new advance zone , public network with vlan > > > Thanks, > > Jijun > >
