----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12942/#review24129 -----------------------------------------------------------
Ship it! - Prasanna Santhanam On July 25, 2013, 12:50 p.m., Girish Shilamkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12942/ > ----------------------------------------------------------- > > (Updated July 25, 2013, 12:50 p.m.) > > > Review request for cloudstack, Murali Reddy and Prasanna Santhanam. > > > Bugs: CLOUDSTACK-3454 > > > Repository: cloudstack-git > > > Description > ------- > > Added isportable param to associateIP API. Fixed base class > for PortableIP tio call portableip APIs. > Removed test_createPortablePublicIPAcquire from basic zone run > requires additional network creation handling which can be done > in component tests. > > > Diffs > ----- > > test/integration/smoke/test_portable_publicip.py 9a3a398 > tools/marvin/marvin/integration/lib/base.py 0f6fdc5 > > Diff: https://reviews.apache.org/r/12942/diff/ > > > Testing > ------- > > Yes, but disassociating ip address fails. Maybe a product defect, yet to > investigate. > > > Thanks, > > Girish Shilamkar > >
